Every style of device has it's advantages and disadvantages but in the end you need to find one that will fit your lifestyle. If you're looking for long term wear, then you're probably going to be best off with a cage (tube) that's about the size your flaccid penis, with somewhat shorter being better than longer. What happens with a "ball trap" device when you get an erection is that your penis pushes against the tube, taking the base ring and your testicles with it. That can be uncomfortable or even painful. A smaller tube helps "curb" an erection, minimizing discomfort. Super short tubes can be visually and emotionally appealing but many men don't find them suitable for long term wear. I have a super short cage like this one and find that with the slightest erection, the end of my penis is poking through bars at the end. I don't find that aesthetically appealing or comfortable. Let us know if you have any other questions.
As @Adam444 says you need to find one that fits. Not to big, Not to small, Just right for you. If you’ve ever been in a group shower you’ll know that every penise is different so every cage is also different. Good Luck
Thank you for the advice, I think the one I have with a 50mm ring but small cage isn’t right for me , it seems to cut the circulation off . But I do work outside a lot of the time so the sack shrinks up. Do you think this is the problem ?